logic scope coding

[promach]

Could anyone give general comments on https://github.com/promach/internal_logic_analyzer/tree/development/rtl ?

Is my coding approach too software-centric ?

 

[Mark Curry]

In article <c4efe3cd-b8c4-4fc7-846d-20871e1edd27@googlegroups.com>,
promach <feiphung27@gmail.com> wrote:

Could anyone give general comments on https://github.com/promach/internal_logic_analyzer/tree/development/rtl ?

Is my coding approach too software-centric ?

From just a quick look, my only recommendation would be to avoid the `defines
within the RTL code, and use parameters instead. You've got some parameters
in the code, but `defines elsewhere. I'd recommend standardizing on parameters.

`defines are global in scope, and not recommended for the way you're using them.
Imagine a design requiring two of your logic_analyzer - each with its own
configuration.

Regards,

Mark